Skip to content

Update solver_specific example due to failure#155

Open
arnavk23 wants to merge 2 commits into
JuliaSmoothOptimizers:mainfrom
arnavk23:main
Open

Update solver_specific example due to failure#155
arnavk23 wants to merge 2 commits into
JuliaSmoothOptimizers:mainfrom
arnavk23:main

Conversation

@arnavk23
Copy link
Copy Markdown
Contributor

@arnavk23 arnavk23 commented May 21, 2026

@tmigot The rendering failure was caused by the newly added example in the solver_specific section: calling bmark_solvers in this environment triggers UndefVarError: reset! during weaving, which then broke the generated page content. I reproduced this locally from the same weave/parse pipeline and confirmed the failing error block in index.md:560

Copilot AI review requested due to automatic review settings May 21, 2026 15:23
@arnavk23 arnavk23 changed the title changing example due to failure Update solver_specific example due to failure May 21, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates the tutorial example for solver-specific statistics to use a minimal ADNLPModels-based setup instead of running a full benchmark over NLPModelsTest problems.

Changes:

  • Replaced the benchmark-based example (bmark_solvers, NLPModelsTest.BROWNDEN()) with a simple ADNLPModel and direct GenericExecutionStats usage.
  • Removed DataFrames/NLPModelsTest/SolverBenchmark imports from the example snippet.
  • Updated the demonstration output to show stats.solver_specific directly.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tutorials/introduction-to-solverbenchmark/index.jmd Outdated
Comment thread tutorials/introduction-to-solverbenchmark/index.jmd Outdated
Comment thread tutorials/introduction-to-solverbenchmark/index.jmd Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants